Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Fix bug about doing estimateGas for blob contract call. #28929

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Feb 5, 2024

Hello guys I am a taiko employee, when I debug eip4844 tx found a bug about blobhash not found when calling FillTransaction for blob tx.

@rjl493456442
Copy link
Member

@s1na Please take a look. Looks like a valid fix for me.

@s1na
Copy link
Contributor

s1na commented Feb 5, 2024

Can you please provide more info when this error happens exactly possibly the API request you sent. I'm failing to reproduce locally.

@mask-pp
Copy link
Contributor Author

mask-pp commented Feb 6, 2024

Can you please provide more info when this error happens exactly possibly the API request you sent. I'm failing to reproduce locally.

Finding this problem is not easy. I will give the running environment later.

@mask-pp
Copy link
Contributor Author

mask-pp commented Feb 6, 2024

Can you please provide more info when this error happens exactly possibly the API request you sent. I'm failing to reproduce locally.

We can reproduce this bug by following the steps:

git clone git@github.com:taikoxyz/taiko-client.git
cd taiko-client

# use eip4844_bug_environment branch
git checkout eip4844_bug_environment

# start docker compose
./internal/docker/start.sh

# run test case.
cd pkg/solidity
go test -v -run TestBlob

We used the FillTransaction API at this line.
The test case(TestBlob) shows that if opts.GasLimit == 0 will run this line and then appear error otherwise run succeed.

@mask-pp
Copy link
Contributor Author

mask-pp commented Feb 8, 2024

@s1na The test environment is ready to reproduce. Thanks for verifying!

@fjl fjl merged commit f1c27c2 into ethereum:master Feb 9, 2024
2 checks passed
@fjl fjl added this to the 1.13.13 milestone Feb 9, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants